feat: table-col-sort-button: opt-in to prefer-fixed-positioning for dropdown #5338
Conversation
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
| it('col-sort-button-dropdown-open-short-flag-off', async() => { | ||
| window.D2L = {}; | ||
| const elem = await createTableFixture(html` | ||
| <thead>${createSortableButtonDropdownHeaderRow()}</thead> | ||
| <tbody>${createRows([1])}</tbody> | ||
| `); | ||
| await clickElem(elem.shadowRoot.querySelector('d2l-table-col-sort-button')); | ||
| await expect(elem).to.be.golden(); | ||
| }); |
There was a problem hiding this comment.
Not totally necessary, though it shows the problem. Would eventually get removed.
components/table/demo/table.html
Outdated
| @@ -8,6 +8,9 @@ | |||
| import '../../demo/demo-page.js'; | |||
| import './table-test.js'; | |||
| </script> | |||
| <script> | |||
| window.D2L = { LP: { Web: { UI: { Flags: { Flag: () => true } } } } }; | |||
There was a problem hiding this comment.
Why was this part needed? I would have expected any code checking a flag to use an optional chain on this. I guess if it's not defaulting to true after that?
There was a problem hiding this comment.
Copy pasted from another spot - I'll check if I can simplify
There was a problem hiding this comment.
Ah yup nevermind it wasn't defaulting to true so that was why this was needed.
There was a problem hiding this comment.
Cool. Wonder if it's worth a comment with the flag name just so we know we can remove this when either the flag defaults to true or is removed entirely? Otherwise this page could end up with some weird behaviour in the future!
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
margaree
deleted the
table-col-sort-button-opt-in-prefer-fixed-positioning
branch
|
🎉 This PR is included in version 3.82.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Jira ticket